jadedctrl/ Pogger
1
0
Disbranĉigi 0
Fontkodo Issues 4 Tirpetoj Activity

Feed number in notifications

This commit is contained in:
Jaidyn Ann 2021-03-07 14:08:47 -06:00
parent c4990b719c
commit c642c911fa
3 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
TODO.txt
View File

@ -5,9 +5,9 @@ Important Features:
Important improvements:
* Memory leaks
* ~50kb per feed on download (+2MB w 40 feeds)
* ~.05MB per feed on download (+2MB w 40 feeds)
* This leak is in Util.ccp, fetch(). I'm stumped here.
* ~20kb per feed on parsing (+1MB w 40 feeds)
* ~.02MB per feed on parsing (+1MB w 40 feeds)
* Fix background of Feeds List error status icon (it's black, not transparent)
* Make UI friendly to whatever font-size you throw at it
* Give a max size to the progress label in FeedsView

8
src/FeedListItem.cpp
View File

@ -40,9 +40,11 @@ FeedListItem::DrawItem(BView* owner, BRect frame, bool complete)
}
case kErrorStatus:
{
owner->MovePenTo(frame.right - imageHeight, frame.top);
owner->DrawBitmap(loadVectorIcon("error-status", imageHeight,
imageHeight));
owner->MovePenTo(frame.right - 20, frame.top + BaselineOffset());
owner->DrawString("X");
// owner->MovePenTo(frame.right - imageHeight, frame.top);
// owner->DrawBitmap(loadVectorIcon("error-status", imageHeight,
// imageHeight));
break;
}
}

8
src/Notifier.cpp
View File

@ -100,10 +100,10 @@ Notifier::_SendUpdatedNotification()
BString entryNum,feedNum = "";
entryNum << fTotalEntries;
feedNum << fUpdatedFeeds->CountItems();
feedNum << fUpdatedFeeds->CountItems() - 1;
notifyText.ReplaceAll("%n%", entryNum);
notifyText.ReplaceAll("%m%", feedNum - 1);
notifyText.ReplaceAll("%m%", feedNum);
notifyText.ReplaceAll("%source%",
((BString*)fUpdatedFeeds->ItemAt(0))->String());
@ -134,9 +134,9 @@ Notifier::_SendFailedNotification()
notifyText = "Failed to update %source% and %m% others";
BString feedNum = "";
feedNum << fFailedFeeds->CountItems();
feedNum << fFailedFeeds->CountItems() - 1;
notifyText.ReplaceAll("%m%", feedNum - 1);
notifyText.ReplaceAll("%m%", feedNum);
notifyText.ReplaceAll("%source%",
((BString*)fFailedFeeds->ItemAt(0))->String());