minor improvements

components/LinkViews/LinkComponents/LinkActions.tsx

@@ -67,7 +67,8 @@ export default function LinkActions({
   return (
     <>
       <div
-        className={`dropdown dropdown-left dropdown-end absolute ${position || "top-3 right-3"
+        className={`dropdown dropdown-left dropdown-end absolute ${
+          position || "top-3 right-3"
         } z-20`}
       >
         <div
@@ -79,7 +80,6 @@ export default function LinkActions({
           <i title="More" className="bi-three-dots text-xl" />
         </div>
         <ul className="dropdown-content z-[20] menu shadow bg-base-200 border border-neutral-content rounded-box w-44 mr-1 translate-y-10">
-          {permissions ? (
           <li>
             <div
               role="button"
@@ -94,7 +94,6 @@ export default function LinkActions({
                 : "Pin to Dashboard"}
             </div>
           </li>
-          ) : undefined}
           {linkInfo !== undefined && toggleShowInfo ? (
             <li>
               <div

lib/api/controllers/links/linkId/updateLinkById.ts

@@ -21,10 +21,6 @@ export default async function updateLinkById(
     (e: UsersAndCollections) => e.userId === userId && e.canUpdate
   );
 
-  const canCreatePermission = collectionIsAccessible?.members.some(
-    (e: UsersAndCollections) => e.userId === userId && e.canCreate
-  );
-
   const isCollectionOwner =
     collectionIsAccessible?.ownerId === data.collection.ownerId &&
     data.collection.ownerId === userId;
@@ -32,21 +28,19 @@ export default async function updateLinkById(
   const unauthorizedSwitchCollection =
     !isCollectionOwner && collectionIsAccessible?.id !== data.collection.id;
 
-  // Makes sure collection members (non-owners) cannot move a link to/from a collection.
+  const canPinPermission = collectionIsAccessible?.members.some(
-  if (unauthorizedSwitchCollection)
+    (e: UsersAndCollections) => e.userId === userId
-    return {
+  );
-      response: "You can't move a link to/from a collection you don't own.",
-      status: 401,
-    };
 
   // If the user is able to create a link, they can pin it to their dashboard only.
-  if (canCreatePermission) {
+  if (canPinPermission) {
     const updatedLink = await prisma.link.update({
       where: {
         id: linkId,
       },
       data: {
-        pinnedBy: data?.pinnedBy && data.pinnedBy[0]
+        pinnedBy:
+          data?.pinnedBy && data.pinnedBy[0]
             ? { connect: { id: userId } }
             : { disconnect: { id: userId } },
       },
@@ -64,6 +58,12 @@ export default async function updateLinkById(
     return { response: updatedLink, status: 200 };
   }
 
+  // Makes sure collection members (non-owners) cannot move a link to/from a collection.
+  if (unauthorizedSwitchCollection)
+    return {
+      response: "You can't move a link to/from a collection you don't own.",
+      status: 401,
+    };
   else if (collectionIsAccessible?.ownerId !== userId && !memberHasAccess)
     return {
       response: "Collection is not accessible.",