Merge pull request #252 from linkwarden/dev

Dev

components/SubmitButton.tsx

@@ -2,11 +2,12 @@ import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
 import { IconProp } from "@fortawesome/fontawesome-svg-core";
 
 type Props = {
-  onClick: Function;
+  onClick?: Function;
   icon?: IconProp;
   label: string;
   loading: boolean;
   className?: string;
+  type?: "button" | "submit" | "reset" | undefined;
 };
 
 export default function SubmitButton({
@@ -15,20 +16,22 @@ export default function SubmitButton({
   label,
   loading,
   className,
+  type,
 }: Props) {
   return (
-    <div
+    <button
+      type={type ? type : undefined}
       className={`text-white flex items-center gap-2 py-2 px-5 rounded-md text-lg tracking-wide select-none font-semibold duration-100 w-fit ${
         loading
           ? "bg-sky-600 cursor-auto"
           : "bg-sky-700 hover:bg-sky-600 cursor-pointer"
       } ${className}`}
       onClick={() => {
-        if (!loading) onClick();
+        if (!loading && onClick) onClick();
       }}
     >
-      {icon && <FontAwesomeIcon icon={icon} className="h-5 select-none" />}
+      {icon && <FontAwesomeIcon icon={icon} className="h-5" />}
-      <p className="text-center w-full select-none">{label}</p>
+      <p className="text-center w-full">{label}</p>
-    </div>
+    </button>
   );
 }

lib/api/controllers/users/postUser.ts

@@ -54,10 +54,10 @@ export default async function postUser(
   const checkIfUserExists = await prisma.user.findFirst({
     where: emailEnabled
       ? {
-          email: body.email?.toLowerCase(),
+          email: body.email?.toLowerCase().trim(),
         }
       : {
-          username: (body.username as string).toLowerCase(),
+          username: (body.username as string).toLowerCase().trim(),
         },
   });
 
@@ -71,8 +71,8 @@ export default async function postUser(
         name: body.name,
         username: emailEnabled
           ? undefined
-          : (body.username as string).toLowerCase(),
+          : (body.username as string).toLowerCase().trim(),
-        email: emailEnabled ? body.email?.toLowerCase() : undefined,
+        email: emailEnabled ? body.email?.toLowerCase().trim() : undefined,
         password: hashedPassword,
       },
     });

lib/api/controllers/users/userId/updateUserById.ts

@@ -29,6 +29,15 @@ export default async function updateUser(
       status: 400,
     };
 
+  // Check email (if enabled)
+  const checkEmail =
+    /^(([^<>()[\]\.,;:\s@\"]+(\.[^<>()[\]\.,;:\s@\"]+)*)|(\".+\"))@(([^<>()[\]\.,;:\s@\"]+\.)+[^<>()[\]\.,;:\s@\"]{2,})$/i;
+  if (emailEnabled && !checkEmail.test(data.email?.toLowerCase() || ""))
+    return {
+      response: "Please enter a valid email.",
+      status: 400,
+    };
+
   const checkUsername = RegExp("^[a-z0-9_-]{3,31}$");
 
   if (!checkUsername.test(data.username.toLowerCase()))
@@ -58,11 +67,25 @@ export default async function updateUser(
     },
   });
 
-  if (userIsTaken)
+  if (userIsTaken) {
+    if (data.email?.toLowerCase().trim() === userIsTaken.email?.trim())
+      return {
+        response: "Email is taken.",
+        status: 400,
+      };
+    else if (
+      data.username?.toLowerCase().trim() === userIsTaken.username?.trim()
+    )
+      return {
+        response: "Username is taken.",
+        status: 400,
+      };
+
     return {
       response: "Username/Email is taken.",
       status: 400,
     };
+  }
 
   // Avatar Settings
 
@@ -105,8 +128,8 @@ export default async function updateUser(
     },
     data: {
       name: data.name,
-      username: data.username.toLowerCase(),
+      username: data.username.toLowerCase().trim(),
-      email: data.email?.toLowerCase(),
+      email: data.email?.toLowerCase().trim(),
       isPrivate: data.isPrivate,
       archiveAsScreenshot: data.archiveAsScreenshot,
       archiveAsPDF: data.archiveAsPDF,

pages/choose-username.tsx

@@ -1,6 +1,6 @@
 import SubmitButton from "@/components/SubmitButton";
 import { signOut } from "next-auth/react";
-import { useState } from "react";
+import { FormEvent, useState } from "react";
 import { toast } from "react-hot-toast";
 import { useSession } from "next-auth/react";
 import useAccountStore from "@/store/account";
@@ -15,7 +15,9 @@ export default function ChooseUsername() {
 
   const { updateAccount, account } = useAccountStore();
 
-  async function submitUsername() {
+  async function submitUsername(event: FormEvent<HTMLFormElement>) {
+    event.preventDefault();
+
     setSubmitLoader(true);
 
     const redirectionToast = toast.loading("Applying...");
@@ -38,50 +40,53 @@ export default function ChooseUsername() {
 
   return (
     <CenteredForm>
-      <div className="p-4 mx-auto flex flex-col gap-3 justify-between sm:w-[30rem] w-80 bg-slate-50 dark:border-neutral-700 dark:bg-neutral-800 rounded-2xl shadow-md border border-sky-100">
+      <form onSubmit={submitUsername}>
-        <p className="text-2xl text-center text-black dark:text-white font-bold">
+        <div className="p-4 mx-auto flex flex-col gap-3 justify-between sm:w-[30rem] w-80 bg-slate-50 dark:border-neutral-700 dark:bg-neutral-800 rounded-2xl shadow-md border border-sky-100">
-          Choose a Username (Last step)
+          <p className="text-2xl text-center text-black dark:text-white font-bold">
-        </p>
+            Choose a Username (Last step)
-
-        <div>
-          <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
-            Username
           </p>
 
-          <TextInput
+          <div>
-            placeholder="john"
+            <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
-            value={inputedUsername}
+              Username
-            className="bg-white"
+            </p>
-            onChange={(e) => setInputedUsername(e.target.value)}
+
+            <TextInput
+              autoFocus
+              placeholder="john"
+              value={inputedUsername}
+              className="bg-white"
+              onChange={(e) => setInputedUsername(e.target.value)}
+            />
+          </div>
+          <div>
+            <p className="text-md text-gray-500 dark:text-gray-400 mt-1">
+              Feel free to reach out to us at{" "}
+              <a
+                className="font-semibold underline"
+                href="mailto:support@linkwarden.app"
+              >
+                support@linkwarden.app
+              </a>{" "}
+              in case of any issues.
+            </p>
+          </div>
+
+          <SubmitButton
+            type="submit"
+            label="Complete Registration"
+            className="mt-2 w-full text-center"
+            loading={submitLoader}
           />
-        </div>
-        <div>
-          <p className="text-md text-gray-500 dark:text-gray-400 mt-1">
-            Feel free to reach out to us at{" "}
-            <a
-              className="font-semibold underline"
-              href="mailto:support@linkwarden.app"
-            >
-              support@linkwarden.app
-            </a>{" "}
-            in case of any issues.
-          </p>
-        </div>
 
-        <SubmitButton
+          <div
-          onClick={submitUsername}
+            onClick={() => signOut()}
-          label="Complete Registration"
+            className="w-fit mx-auto cursor-pointer text-gray-500 dark:text-gray-400 font-semibold "
-          className="mt-2 w-full text-center"
+          >
-          loading={submitLoader}
+            Sign Out
-        />
+          </div>
-
-        <div
-          onClick={() => signOut()}
-          className="w-fit mx-auto cursor-pointer text-gray-500 dark:text-gray-400 font-semibold "
-        >
-          Sign Out
         </div>
-      </div>
+      </form>
     </CenteredForm>
   );
 }

pages/forgot.tsx

@@ -3,7 +3,7 @@ import TextInput from "@/components/TextInput";
 import CenteredForm from "@/layouts/CenteredForm";
 import { signIn } from "next-auth/react";
 import Link from "next/link";
-import { useState } from "react";
+import { FormEvent, useState } from "react";
 import { toast } from "react-hot-toast";
 
 interface FormData {
@@ -17,7 +17,9 @@ export default function Forgot() {
     email: "",
   });
 
-  async function loginUser() {
+  async function sendConfirmation(event: FormEvent<HTMLFormElement>) {
+    event.preventDefault();
+
     if (form.email !== "") {
       setSubmitLoader(true);
 
@@ -40,49 +42,52 @@ export default function Forgot() {
 
   return (
     <CenteredForm>
-      <div className="p-4 flex flex-col gap-3 justify-between sm:w-[30rem] w-80 bg-slate-50 dark:border-neutral-700 dark:bg-neutral-800 rounded-2xl shadow-md border border-sky-100">
+      <form onSubmit={sendConfirmation}>
-        <p className="text-2xl text-center text-black dark:text-white font-bold">
+        <div className="p-4 flex flex-col gap-3 justify-between sm:w-[30rem] w-80 bg-slate-50 dark:border-neutral-700 dark:bg-neutral-800 rounded-2xl shadow-md border border-sky-100">
-          Password Recovery
+          <p className="text-2xl text-center text-black dark:text-white font-bold">
-        </p>
+            Password Recovery
-        <div>
-          <p className="text-md text-black dark:text-white">
-            Enter your Email so we can send you a link to recover your account.
-            Make sure to change your password in the profile settings
-            afterwards.
-          </p>
-          <p className="text-sm text-gray-500 dark:text-gray-400">
-            You wont get logged in if you haven&apos;t created an account yet.
-          </p>
-        </div>
-        <div>
-          <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
-            Email
           </p>
+          <div>
+            <p className="text-md text-black dark:text-white">
+              Enter your Email so we can send you a link to recover your
+              account. Make sure to change your password in the profile settings
+              afterwards.
+            </p>
+            <p className="text-sm text-gray-500 dark:text-gray-400">
+              You wont get logged in if you haven&apos;t created an account yet.
+            </p>
+          </div>
+          <div>
+            <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
+              Email
+            </p>
 
-          <TextInput
+            <TextInput
-            type="email"
+              autoFocus
-            placeholder="johnny@example.com"
+              type="email"
-            value={form.email}
+              placeholder="johnny@example.com"
-            className="bg-white"
+              value={form.email}
-            onChange={(e) => setForm({ ...form, email: e.target.value })}
+              className="bg-white"
+              onChange={(e) => setForm({ ...form, email: e.target.value })}
+            />
+          </div>
+
+          <SubmitButton
+            type="submit"
+            label="Send Login Link"
+            className="mt-2 w-full text-center"
+            loading={submitLoader}
           />
+          <div className="flex items-baseline gap-1 justify-center">
+            <Link
+              href={"/login"}
+              className="block text-black dark:text-white font-bold"
+            >
+              Go back
+            </Link>
+          </div>
         </div>
-
+      </form>
-        <SubmitButton
-          onClick={loginUser}
-          label="Send Login Link"
-          className="mt-2 w-full text-center"
-          loading={submitLoader}
-        />
-        <div className="flex items-baseline gap-1 justify-center">
-          <Link
-            href={"/login"}
-            className="block text-black dark:text-white font-bold"
-          >
-            Go back
-          </Link>
-        </div>
-      </div>
     </CenteredForm>
   );
 }

pages/login.tsx

@@ -3,7 +3,7 @@ import TextInput from "@/components/TextInput";
 import CenteredForm from "@/layouts/CenteredForm";
 import { signIn } from "next-auth/react";
 import Link from "next/link";
-import { useState } from "react";
+import { useState, FormEvent } from "react";
 import { toast } from "react-hot-toast";
 
 interface FormData {
@@ -21,7 +21,9 @@ export default function Login() {
     password: "",
   });
 
-  async function loginUser() {
+  async function loginUser(event: FormEvent<HTMLFormElement>) {
+    event.preventDefault();
+
     if (form.username !== "" && form.password !== "") {
       setSubmitLoader(true);
 
@@ -47,67 +49,73 @@ export default function Login() {
 
   return (
     <CenteredForm text="Sign in to your account">
-      <div className="p-4 flex flex-col gap-3 justify-between sm:w-[30rem] w-80 bg-slate-50 dark:bg-neutral-800 rounded-2xl shadow-md border border-sky-100 dark:border-neutral-700">
+      <form onSubmit={loginUser}>
-        <p className="text-2xl text-black dark:text-white text-center font-bold">
+        <div className="p-4 flex flex-col gap-3 justify-between sm:w-[30rem] w-80 bg-slate-50 dark:bg-neutral-800 rounded-2xl shadow-md border border-sky-100 dark:border-neutral-700">
-          Enter your credentials
+          <p className="text-2xl text-black dark:text-white text-center font-bold">
-        </p>
+            Enter your credentials
-
-        <div>
-          <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
-            Username
-            {emailEnabled ? " or Email" : undefined}
           </p>
 
-          <TextInput
+          <div>
-            placeholder="johnny"
+            <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
-            value={form.username}
+              Username
-            className="bg-white"
+              {emailEnabled ? " or Email" : undefined}
-            onChange={(e) => setForm({ ...form, username: e.target.value })}
+            </p>
-          />
-        </div>
 
-        <div>
+            <TextInput
-          <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
+              autoFocus={true}
-            Password
+              placeholder="johnny"
-          </p>
+              value={form.username}
+              className="bg-white"
+              onChange={(e) => setForm({ ...form, username: e.target.value })}
+            />
+          </div>
 
-          <TextInput
+          <div>
-            type="password"
+            <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
-            placeholder="••••••••••••••"
+              Password
-            value={form.password}
+            </p>
-            className="bg-white"
+
-            onChange={(e) => setForm({ ...form, password: e.target.value })}
+            <TextInput
+              type="password"
+              placeholder="••••••••••••••"
+              value={form.password}
+              className="bg-white"
+              onChange={(e) => setForm({ ...form, password: e.target.value })}
+            />
+            {emailEnabled && (
+              <div className="w-fit ml-auto mt-1">
+                <Link
+                  href={"/forgot"}
+                  className="text-gray-500 dark:text-gray-400 font-semibold"
+                >
+                  Forgot Password?
+                </Link>
+              </div>
+            )}
+          </div>
+
+          <SubmitButton
+            type="submit"
+            label="Login"
+            className=" w-full text-center"
+            loading={submitLoader}
           />
-          {emailEnabled && (
+          {process.env.NEXT_PUBLIC_DISABLE_REGISTRATION ===
-            <div className="w-fit ml-auto mt-1">
+          "true" ? undefined : (
+            <div className="flex items-baseline gap-1 justify-center">
+              <p className="w-fit text-gray-500 dark:text-gray-400">
+                New here?
+              </p>
               <Link
-                href={"/forgot"}
+                href={"/register"}
-                className="text-gray-500 dark:text-gray-400 font-semibold"
+                className="block text-black dark:text-white font-semibold"
               >
-                Forgot Password?
+                Sign Up
               </Link>
             </div>
           )}
         </div>
-
+      </form>
-        <SubmitButton
-          onClick={loginUser}
-          label="Login"
-          className=" w-full text-center"
-          loading={submitLoader}
-        />
-        {process.env.NEXT_PUBLIC_DISABLE_REGISTRATION === "true" ? undefined : (
-          <div className="flex items-baseline gap-1 justify-center">
-            <p className="w-fit text-gray-500 dark:text-gray-400">New here?</p>
-            <Link
-              href={"/register"}
-              className="block text-black dark:text-white font-semibold"
-            >
-              Sign Up
-            </Link>
-          </div>
-        )}
-      </div>
     </CenteredForm>
   );
 }

pages/register.tsx

@@ -1,5 +1,5 @@
 import Link from "next/link";
-import { useState } from "react";
+import { useState, FormEvent } from "react";
 import { toast } from "react-hot-toast";
 import SubmitButton from "@/components/SubmitButton";
 import { signIn } from "next-auth/react";
@@ -29,7 +29,9 @@ export default function Register() {
     passwordConfirmation: "",
   });
 
-  async function registerUser() {
+  async function registerUser(event: FormEvent<HTMLFormElement>) {
+    event.preventDefault();
+
     const checkFields = () => {
       if (emailEnabled) {
         return (
@@ -107,134 +109,139 @@ export default function Register() {
           </p>
         </div>
       ) : (
-        <div className="p-4 flex flex-col gap-3 justify-between sm:w-[30rem] w-80 bg-slate-50 dark:bg-neutral-800 rounded-2xl shadow-md border border-sky-100 dark:border-neutral-700">
+        <form onSubmit={registerUser}>
-          <p className="text-2xl text-black dark:text-white text-center font-bold">
+          <div className="p-4 flex flex-col gap-3 justify-between sm:w-[30rem] w-80 bg-slate-50 dark:bg-neutral-800 rounded-2xl shadow-md border border-sky-100 dark:border-neutral-700">
-            Enter your details
+            <p className="text-2xl text-black dark:text-white text-center font-bold">
-          </p>
+              Enter your details
-          <div>
-            <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
-              Display Name
             </p>
-
-            <TextInput
-              placeholder="Johnny"
-              value={form.name}
-              className="bg-white"
-              onChange={(e) => setForm({ ...form, name: e.target.value })}
-            />
-          </div>
-
-          {emailEnabled ? undefined : (
             <div>
               <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
-                Username
+                Display Name
               </p>
 
               <TextInput
-                placeholder="john"
+                autoFocus={true}
-                value={form.username}
+                placeholder="Johnny"
+                value={form.name}
                 className="bg-white"
-                onChange={(e) => setForm({ ...form, username: e.target.value })}
+                onChange={(e) => setForm({ ...form, name: e.target.value })}
               />
             </div>
-          )}
 
-          {emailEnabled ? (
+            {emailEnabled ? undefined : (
-            <div>
+              <div>
-              <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
+                <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
-                Email
+                  Username
+                </p>
+
+                <TextInput
+                  placeholder="john"
+                  value={form.username}
+                  className="bg-white"
+                  onChange={(e) =>
+                    setForm({ ...form, username: e.target.value })
+                  }
+                />
+              </div>
+            )}
+
+            {emailEnabled ? (
+              <div>
+                <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
+                  Email
+                </p>
+
+                <TextInput
+                  type="email"
+                  placeholder="johnny@example.com"
+                  value={form.email}
+                  className="bg-white"
+                  onChange={(e) => setForm({ ...form, email: e.target.value })}
+                />
+              </div>
+            ) : undefined}
+
+            <div className="w-full">
+              <p className="text-sm text-black dark:text-white w-fit font-semibold  mb-1">
+                Password
               </p>
 
               <TextInput
-                type="email"
+                type="password"
-                placeholder="johnny@example.com"
+                placeholder="••••••••••••••"
-                value={form.email}
+                value={form.password}
                 className="bg-white"
-                onChange={(e) => setForm({ ...form, email: e.target.value })}
+                onChange={(e) => setForm({ ...form, password: e.target.value })}
               />
             </div>
-          ) : undefined}
 
-          <div className="w-full">
+            <div className="w-full">
-            <p className="text-sm text-black dark:text-white w-fit font-semibold  mb-1">
+              <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
-              Password
+                Confirm Password
-            </p>
-
-            <TextInput
-              type="password"
-              placeholder="••••••••••••••"
-              value={form.password}
-              className="bg-white"
-              onChange={(e) => setForm({ ...form, password: e.target.value })}
-            />
-          </div>
-
-          <div className="w-full">
-            <p className="text-sm text-black dark:text-white w-fit font-semibold mb-1">
-              Confirm Password
-            </p>
-
-            <TextInput
-              type="password"
-              placeholder="••••••••••••••"
-              value={form.passwordConfirmation}
-              className="bg-white"
-              onChange={(e) =>
-                setForm({ ...form, passwordConfirmation: e.target.value })
-              }
-            />
-          </div>
-
-          {process.env.NEXT_PUBLIC_STRIPE_IS_ACTIVE ? (
-            <div>
-              <p className="text-xs text-gray-500 dark:text-gray-400">
-                By signing up, you agree to our{" "}
-                <Link
-                  href="https://linkwarden.app/tos"
-                  className="font-semibold underline"
-                >
-                  Terms of Service
-                </Link>{" "}
-                and{" "}
-                <Link
-                  href="https://linkwarden.app/privacy-policy"
-                  className="font-semibold underline"
-                >
-                  Privacy Policy
-                </Link>
-                .
-              </p>
-              <p className="text-xs text-gray-500 dark:text-gray-400">
-                Need help?{" "}
-                <Link
-                  href="mailto:support@linkwarden.app"
-                  className="font-semibold underline"
-                >
-                  Get in touch
-                </Link>
-                .
               </p>
+
+              <TextInput
+                type="password"
+                placeholder="••••••••••••••"
+                value={form.passwordConfirmation}
+                className="bg-white"
+                onChange={(e) =>
+                  setForm({ ...form, passwordConfirmation: e.target.value })
+                }
+              />
             </div>
-          ) : undefined}
 
-          <SubmitButton
+            {process.env.NEXT_PUBLIC_STRIPE_IS_ACTIVE ? (
-            onClick={registerUser}
+              <div>
-            label="Sign Up"
+                <p className="text-xs text-gray-500 dark:text-gray-400">
-            className="mt-2 w-full text-center"
+                  By signing up, you agree to our{" "}
-            loading={submitLoader}
+                  <Link
-          />
+                    href="https://linkwarden.app/tos"
-          <div className="flex items-baseline gap-1 justify-center">
+                    className="font-semibold underline"
-            <p className="w-fit text-gray-500 dark:text-gray-400">
+                  >
-              Already have an account?
+                    Terms of Service
-            </p>
+                  </Link>{" "}
-            <Link
+                  and{" "}
-              href={"/login"}
+                  <Link
-              className="block text-black dark:text-white font-bold"
+                    href="https://linkwarden.app/privacy-policy"
-            >
+                    className="font-semibold underline"
-              Login
+                  >
-            </Link>
+                    Privacy Policy
+                  </Link>
+                  .
+                </p>
+                <p className="text-xs text-gray-500 dark:text-gray-400">
+                  Need help?{" "}
+                  <Link
+                    href="mailto:support@linkwarden.app"
+                    className="font-semibold underline"
+                  >
+                    Get in touch
+                  </Link>
+                  .
+                </p>
+              </div>
+            ) : undefined}
+
+            <SubmitButton
+              type="submit"
+              label="Sign Up"
+              className="mt-2 w-full text-center"
+              loading={submitLoader}
+            />
+            <div className="flex items-baseline gap-1 justify-center">
+              <p className="w-fit text-gray-500 dark:text-gray-400">
+                Already have an account?
+              </p>
+              <Link
+                href={"/login"}
+                className="block text-black dark:text-white font-bold"
+              >
+                Login
+              </Link>
+            </div>
           </div>
-        </div>
+        </form>
       )}
     </CenteredForm>
   );