From 57dcb1d4d238709052691928ca0505d63f8b9a50 Mon Sep 17 00:00:00 2001
From: Juraj Vajda <juraj.vajda@gmail.com>
Date: Mon, 24 Oct 2022 16:31:23 -0400
Subject: [PATCH] Improve arrow visibility

---
 api.lua                        |   5 ++++-
 init.lua                       |   1 +
 models/x_bows_arrow.b3d        | Bin 43088 -> 43088 bytes
 particle_effects.lua           |  26 +++++++++++++++++++-------
 textures/x_bows_arrow_mesh.png | Bin 236 -> 235 bytes
 5 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/api.lua b/api.lua
index 852e21a..7d41d4f 100644
--- a/api.lua
+++ b/api.lua
@@ -197,6 +197,7 @@ function XBows.register_bow(self, name, def, override)
         inventory_image = def.inventory_image or 'x_bows_bow_wood.png',
         wield_image = def.wield_image or def.inventory_image,
         groups = def.groups,
+        wield_scale = {x = 2, y = 2, z = 1.5},
         ---@param itemstack ItemStack
         ---@param placer ObjectRef|nil
         ---@param pointed_thing PointedThingDef
@@ -223,6 +224,7 @@ function XBows.register_bow(self, name, def, override)
         inventory_image = def.custom.inventory_image_charged or 'x_bows_bow_wood_charged.png',
         wield_image = def.custom.wield_image_charged or def.custom.inventory_image_charged,
         groups = def.custom.groups_charged,
+        wield_scale = {x = 2, y = 2, z = 1.5},
         ---@param itemstack ItemStack
         ---@param user ObjectRef|nil
         ---@param pointed_thing PointedThingDef
@@ -1334,7 +1336,8 @@ function XBows.register_entity(self, name, def)
         physical = false,
         textures = {'air'},
         hp_max = 1,
-        visual_size = {x = 1, y = 1, z = 1}
+        visual_size = {x = 1, y = 1, z = 1},
+        glow = 1
     }, def.initial_properties or {})
 
     def.on_death = function(selfObj, killer)
diff --git a/init.lua b/init.lua
index 0126b01..e8f2335 100644
--- a/init.lua
+++ b/init.lua
@@ -46,6 +46,7 @@ minetest.register_globalstep(function(dtime)
             end
 
             if minetest.get_item_group(wielded_stack_name, 'bow_charged') ~= 0 and not XBows.player_bow_sneak[player_name].sneak then
+                --charged weapon
                 if XBows.playerphysics then
                     playerphysics.add_physics_factor(player, 'speed', 'x_bows:bow_charged_speed', 0.25)
                 elseif XBows.player_monoids then
diff --git a/models/x_bows_arrow.b3d b/models/x_bows_arrow.b3d
index 07bdef9430bd4480ca7a2de6071a6a23d6aabe4e..7d7e2867477d5c28968310390903960b60fda2dc 100644
GIT binary patch
delta 678
zcmX}pUr19?9KiA8oVv~3>2&J;Brf^=w4xDVNSm%JxE^{?sF!?-GAbwu>M4kJwU8(w
zkPE|TP8~}N`)4n;>FAG$MGhATfoR}Ev%+N4)S2v_&Q8$7dHL`?=XcLN@wh4;SG{-}
zELw?4Vw2hK?w;9z56fzKHdtwlRd~hMx3=9^m%qZHkO6b$&q15<`idm(-JG7NDbL04
zPqsnLwRMiQ!O7^^P$8C_PCy>l97PfXW3(ZvWZ=C*FkkL{XfrlHmPE(s3HMX)8Wdj4
z#{%9qQAu3-;UDkw6YQB%K*L-8CrPXygs4xKhuF0NT6t)sO6Xtpg(WS)=3f+aysJw|
z;w9^|#v7e~pkz#ig;|yDA+?aV(C$p8DAW`X)blpIDTxF0_QYMA3N5d8K;ZLN*!=Ug
zGZ8}_!Oi;=3|#MJ*!*6h@xpWlwk<hW^zQ`L`VVxuyl*J9*$EbNy~%Eyax9K}7YH8p
zC}8CJo3&G(!H9Ja!Q^uaCH!1J)A@n+25Th+#}$I5Tz8lbd5*b0#wgTV2%5M~GW}^d
zIDV~-;9M((GOih>Wxl3JwV7agmO?q#HKyGiFJ1G)6hiw6R&Z6AUan0!x0WdEE+S~=
znr3>gqbHK6CfFXKV3AY9Rf4h=3$N-4o=Q-#{@<-^X<hw`6k3b~ZTt<q?>e2@B!x;1
z!CkB?wPe32yC_=^M!$sb2n6?iV@0;tok_QZz4-)>tjmFsYC%(c+^Juu(8s7M`=j_{
VoeU7CDNVtoCTP!Ylg*C~{{>>cDi;6%

delta 686
zcmY+BT}YEr7{^cByE!+f&e__WQ<LWj)SHEUI6rzZBnrAvF)xIW0x9Umun$P`O``_h
zzKQmMq+td^21c|GX%&SewOJ9%28n{A&QaMu(%9+jTnxH6H^1|H{?GrsZy=xu1Qbtv
zqd9|1k~n1lS!-`g!0<Dr>>srmUaj|t`k<#S)VTs(l{!?)bE8H}l1gIg=%SL?931e*
zniP2U$TkS<)@oR5mBc!gJpJ{X2HRs{P|3XytcHc8Bnnzz&00?q`d<)KbGO1TiFYkU
zb(0%W=n4v$!RalQJ-`2)=fXvTSMw=o{@Yr)D2Ws5xVPcG60PM4$mIEiToZ>@PPvLQ
z2$EkEv^?o?ToUbreYJ+AZD>#{P$!R!7wa24${m-Y6i%xMX7TCpmL%R&9QXDQ>_9U6
z7xa8O#(Jo1x82Qq2s)=IWOI6-y=1cObB(4o3GPn>b5c~cKNR%6GxgOIehNp;1arAt
z#u6fnV;<)i!Ru2=FmU>Z(e5*yZc7nC`kF!>?=ZvYYP_r_a)QE-7J|lf?tx8Hb^APp
zjXZ++JmEWYTV@4M$6<o|x+(1B?gHx&>CAQ8m?wlNn9|!0&fTcCPgCgKO>kG*{StcW
z=v$?5Qb*9tJ8ZMuL}`<IZvnxNvlJ}+d%3UNaXrsuBut?oJ$-ERgX7RLg=7{%EBD@(
z)H`&)DVWs+3)9~Dmm{tUEy3k=3bxdi?9{({(_P?N5(r+7$;0EN`kU_x9gQ&xQHF|n
Vm~+inW!j=(R1z#n5!w8x>K}-~DmMTC

diff --git a/particle_effects.lua b/particle_effects.lua
index b011a0f..78fbfb1 100644
--- a/particle_effects.lua
+++ b/particle_effects.lua
@@ -1,8 +1,8 @@
 XBows:register_particle_effect('arrow', {
     amount = 1,
     time = 0.1,
-    minexptime = 1,
-    maxexptime = 1,
+    minexptime = 0.5,
+    maxexptime = 0.5,
     minsize = 2,
     maxsize = 2,
     texture = 'x_bows_arrow_particle.png',
@@ -12,11 +12,15 @@ XBows:register_particle_effect('arrow', {
         aspect_h = 8,
         length = 1,
     },
-    glow = 1
+    glow = 1,
+    minvel = {x = 0, y = -0.1, z = 0},
+    maxvel = {x = 0, y = -0.1, z = 0},
+    minacc = {x = 0, y = -0.1, z = 0},
+    maxacc = {x = 0, y = -0.1, z = 0}
 })
 
 XBows:register_particle_effect('arrow_crit', {
-    amount = 3,
+    amount = 1,
     time = 0.1,
     minexptime = 0.5,
     maxexptime = 0.5,
@@ -29,11 +33,15 @@ XBows:register_particle_effect('arrow_crit', {
         aspect_h = 8,
         length = 1,
     },
-    glow = 1
+    glow = 1,
+    minvel = {x = 0, y = -0.1, z = 0},
+    maxvel = {x = 0, y = -0.1, z = 0},
+    minacc = {x = 0, y = -0.1, z = 0},
+    maxacc = {x = 0, y = -0.1, z = 0}
 })
 
 XBows:register_particle_effect('arrow_fast', {
-    amount = 3,
+    amount = 1,
     time = 0.1,
     minexptime = 0.5,
     maxexptime = 0.5,
@@ -46,7 +54,11 @@ XBows:register_particle_effect('arrow_fast', {
         aspect_h = 8,
         length = 1,
     },
-    glow = 1
+    glow = 1,
+    minvel = {x = 0, y = -0.1, z = 0},
+    maxvel = {x = 0, y = -0.1, z = 0},
+    minacc = {x = 0, y = -0.1, z = 0},
+    maxacc = {x = 0, y = -0.1, z = 0}
 })
 
 XBows:register_particle_effect('bubble', {
diff --git a/textures/x_bows_arrow_mesh.png b/textures/x_bows_arrow_mesh.png
index 0447c9fa7c1e5ce27cd3b13901d94ab93802ece1..93f05e2faa79004b75e1ad45a0593ca0ca7d2f55 100644
GIT binary patch
delta 199
zcmV;&0672b0qX&fEPv$W<dcqwudJoo+S>5&@I5XhQ9Upw9T#m>KK1qW<>cVL!}eeR
z0004WQchC<K<3zH0001WNkl<Zc-mcyK?(yg3<D)wj+5;F|6654DO3l;FdqC*t)z+>
zmrLR%pX}W<M`UFBdXM>nJw5Z7qsLq;>-Zms{AXTEpbB7yE<g(^a%YghoTcN7nJxDN
z`}N3Z`)-tEK}O~A6d}1+zWwp#BBcHG*hEx4_y9xM0^<`dxljNA002ovPDHLkV1m8a
BUl9NR

delta 200
zcmV;(05|{Z0qg;gEPt<yi%~r=udJoUr={J?$CHkT<=x!n<lsFnBqkjfZB#zq-NNMn
z0004WQchC<K<3zH0001XNkl<Zc-mc#Q3^yc2m_6Y`r6+AzN@b+3!4vN7$UL%z(FCz
zyc~c^dg$e9&Sa8(J5Te4_L9c0y?pI+7~_AOU}p0<Fd@vu#6e{kLMrAw*gG&jL^`^^
ztX^--8Q?yXT1XijFUV#j!M8s?5K5rF-b$7ck9`1V_yZ>!(REG$0000<MNUMnLSTYT
Cds=n?