With-files-write macro #6

Merged

BnMcGn merged 3 commits from master into master

2021-06-26 21:50:21 -05:00

BnMcGn commented

2021-06-25 17:48:48 -05:00

(Migrated from github.com)

Hi Jaidyn,

I've implemented a convenience macro for files-write. For now, I have put it into the main file. Are you OK with add-ons going in the main file or should they go in another file or package? I'm a bit worried about cluttering up the api interface.

There are also a couple of bug fixes included, one of which seems to be the result of IPFS daemon version changes. I'm running 0.8.0 currently. Hopefully I didn't damage anything for other versions.

All the best,
Ben

Hi Jaidyn, I've implemented a convenience macro for files-write. For now, I have put it into the main file. Are you OK with add-ons going in the main file or should they go in another file or package? I'm a bit worried about cluttering up the api interface. There are also a couple of bug fixes included, one of which seems to be the result of IPFS daemon version changes. I'm running 0.8.0 currently. Hopefully I didn't damage anything for other versions. All the best, Ben

JadedCtrl commented

2021-06-26 21:50:13 -05:00

(Migrated from github.com)

Useful macro! I'm not against adding convenience functions to the main package, unless they're too niche or not generally useful― write-with-files is general, for sure. I wouldn't worry about it. :-)

Cheers, and thanks for sharing the good commits!

Useful macro! I'm not against adding convenience functions to the main package, unless they're too niche or not generally useful― `write-with-files` is general, for sure. I wouldn't worry about it. :-) Cheers, and thanks for sharing the good commits!